Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • M merle-scripts
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 8
    • Issues 8
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 0
    • Merge requests 0
  • Deployments
    • Deployments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • cof-geek-sysadmin
  • merle-scripts
  • Merge requests
  • !6

cas_bridge: preserve mattermost name

  • Review changes

  • Download
  • Patches
  • Plain diff
Merged Théophile Bastian requested to merge preserve_mattermost_name into master Jan 31, 2019
  • Overview 0
  • Commits 1
  • Changes 4

Instead of fetching LDAP data for a user, first try to fetch Mattermost data. If the data is present, use it; otherwise, fallback to LDAP data.

This applies currently only to the user's name.

This also fixes LDAP cache being previously ignored (the DB changes were not committed).

Important note

This commit breaks a database model. However, the database for cas_bridge is only used for caching and auth tokens. This means that the database can be harmlessly deleted and re-created from scratch with the right schema, the only consequences being

  • the data being fetched again from LDAP and Mattermost the next time (cache cleared) and
  • the auth current sessions being invalidated: each OAuth token is invalidated, but Mattermost auth cookies are still valid.
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: preserve_mattermost_name