Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • D django-allauth-ens
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 5
    • Issues 5
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 0
    • Merge requests 0
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Klub Dev ENSKlub Dev ENS
  • django-allauth-ens
  • Merge requests
  • !7

Complete !1

  • Review changes

  • Download
  • Patches
  • Plain diff
Closed Aurélien Delobelle requested to merge aureplop/fix-mr1 into master May 15, 2018
  • Overview 1
  • Commits 1
  • Pipelines 0
  • Changes 4

Tests are failing on master. It fixes that.

  • Force python-ldap >= 3 to get proper bytes/string management.
  • Replace common['name'] with common['first_name'] because the name is already broken by get_names. Actually, allauth breaks down common['name'] in 'first_name + last_name'.
  • Decrease timeout of LDAP requests to 5s.
  • Fix get_names in case the LDAP returned a string without any space character.
  • Fix get_names in case the LDAP doesn't return any cn, which was failing with Py3.
  • Add tests about populating user data from LDAP.
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: aureplop/fix-mr1